Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set the dns domain in kubernetes cluster #405

Merged
merged 2 commits into from
May 15, 2020
Merged

Add option to set the dns domain in kubernetes cluster #405

merged 2 commits into from
May 15, 2020

Conversation

BaronMsk
Copy link
Contributor

@BaronMsk BaronMsk commented Apr 30, 2020 •
edited
Loading

Add two features:

  1. Options DnsDomain

@BaronMsk BaronMsk requested a review from a team as a code owner April 30, 2020 08:12
@BaronMsk BaronMsk changed the title Add option dns_domain, disable install cni_network_provider Add option dns_domain Apr 30, 2020
@sheenaajay
Copy link
Contributor

Thanks @BaronMsk for submitting the PR. Will run the Acceptance tests and let you know the status. Thank you.

@sheenaajay sheenaajay changed the title Add option dns_domain Add option to set the dns domain in kubernetes cluster May 15, 2020
@sheenaajay
Copy link
Contributor

Great Work. Thank you.

@sheenaajay sheenaajay merged commit e952a08 into puppetlabs:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BaronMsk @sheenaajay