Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates docker yumrepo default #436

Merged

Conversation

JasonWhall
Copy link
Contributor

Addresses #378

The current default value is not valid and this default value is not reflected in the documentation.

This PR adds a valid yumrepo baseurl for CentOS 7 and updates documentation to reflect this value.

- Current default value is not valid
- Updates docs to reflect new value
@JasonWhall JasonWhall requested a review from a team as a code owner September 2, 2020 10:14
@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::repos is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #436 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #436   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines         44      44           
=====================================
  Misses        44      44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6f6cb...19efd00. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @JasonWhall, this looks good! Thank you four your contribution! Cheers!

@daianamezdrea daianamezdrea merged commit 616c271 into puppetlabs:main Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants