Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options for conntrack settings in v1beta1 and v1beta2 #447

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

Wiston999
Copy link
Contributor

This PR adds support for configuring conntrack settings in kubeadm config.yaml file.

@Wiston999 Wiston999 requested a review from a team as a code owner November 5, 2020 12:10
@puppet-community-rangefinder
Copy link

kubernetes::config::kubeadm is a class

that may have no external impact to Forge modules.

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea daianamezdrea self-assigned this Nov 16, 2020
@daianamezdrea
Copy link
Contributor

Hi @Wiston999, thank you for your PR, it looks very good ! I saw that your fork is a little bit behind and when I tried to test your changes I encountered a conflict in init.pp file. Could you please rebase it? Let me know if you need help with something ! Cheers!

@Wiston999 Wiston999 changed the base branch from master to main November 16, 2020 15:53
@Wiston999
Copy link
Contributor Author

@daianamezdrea I rebased my branch with main and changed the PR base branch from master to main. I hope that conflits are solved now.

@daianamezdrea
Copy link
Contributor

Hi @Wiston999, thank you for your fast response and availability, this looks really nice! Cheers!

@daianamezdrea daianamezdrea merged commit a5a3233 into puppetlabs:main Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants