Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid kube-proxy config resourceContainer #448

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Remove invalid kube-proxy config resourceContainer #448

merged 1 commit into from
Nov 16, 2020

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Nov 5, 2020

Commit to remove applies to Kubernetes 1.16.0+
kubernetes/kubernetes@eee3e97

Error with this config deployed on 1.17.2:

W1105 15:55:06.751793   19570 strict.go:54] error unmarshaling configuration schema.GroupVersionKind{Group:"kubeproxy.config.k8s.io", Version:"v1alpha1", Kind:"KubeProxyConfiguration"}: error unmarshaling JSON: while decoding JSON: json: unknown field "resourceContainer"

@treydock treydock requested a review from a team as a code owner November 5, 2020 21:01
@daianamezdrea daianamezdrea self-assigned this Nov 9, 2020
@daianamezdrea
Copy link
Contributor

Hi @treydock, this looks good! Thank you for your PR! Cheers!

@daianamezdrea daianamezdrea merged commit 72ccf30 into puppetlabs:main Nov 16, 2020
@treydock treydock deleted the rm-resourceContainer branch November 20, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daianamezdrea daianamezdrea

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treydock @daianamezdrea @sanfrancrisko