Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing containerd using a package #460

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Dec 4, 2020

To maintain backwards compatibility I made the package install of containerd opt-in via a parameter. If it would be preferred I can make the package install method the only way to install containerd.

Docs: https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd

One motivation behind this is being able to use Puppet to pin package versions, where the archive approach doesn't lend itself to upgrades via Puppet without deleting something like /usr/bin/runc or /usr/bin/containerd and re-running Puppet. Also Kubernetes 1.20 future release will deprecate Docker as container runtime so felt it would be good to improve on the containerd install method.

Also noticed a bug where the docker apt pinning was pinning kubernetes packages and the kubernetes apt pinning was referencing docker packages.

@treydock treydock requested a review from a team as a code owner December 4, 2020 15:19
@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::packages is a class

that may have no external impact to Forge modules.

kubernetes::service is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea
Copy link
Contributor

Hi @treydock, nice work, thank you for your PR! I tested your changes and everything looks fine!

@daianamezdrea daianamezdrea merged commit 09c8c84 into puppetlabs:main Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants