Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add etc max-request-bytes option #464

Merged

Conversation

AblionGE
Copy link

The goal of the PR is to be able to specifiy the --max-request-bytes option for etcd managed by the module.

@AblionGE AblionGE requested a review from a team as a code owner December 14, 2020 18:04
@puppet-community-rangefinder
Copy link

kubernetes::config::kubeadm is a class

that may have no external impact to Forge modules.

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@AblionGE AblionGE force-pushed the feature/add-max-request-bytes-etcd branch from fadae3f to 2f761d8 Compare December 14, 2020 18:16
@AblionGE AblionGE force-pushed the feature/add-max-request-bytes-etcd branch from 2f761d8 to 9729ac2 Compare December 14, 2020 18:19
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #464 (9729ac2) into main (09c8c84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #464   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines         44      44           
=====================================
  Misses        44      44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c8c84...9729ac2. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @AblionGE, this looks good! Thank you for your contribution !

@daianamezdrea daianamezdrea merged commit 32c6f05 into puppetlabs:main Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants