Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to containerd configs when using a package #510

Merged
merged 3 commits into from May 10, 2021

Conversation

treydock
Copy link
Contributor

  • Update default configs to reflect those generated with containerd v1.4.3
  • Support using NVIDIA container runtime with containerd
  • Allow containerd configs to have template and source changed for customization

@treydock treydock requested a review from a team as a code owner April 20, 2021 15:16
@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::packages is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea
Copy link
Contributor

daianamezdrea commented Apr 27, 2021

Hi @treydock, thank you for submitting the PR, I've just merged a couple of PRs, could you rebase please ?

@treydock
Copy link
Contributor Author

@daianamezdrea I've rebased

@treydock
Copy link
Contributor Author

Test failures look like testing didn't wait long enough for Kubernetes worker node to become ready.

@daianamezdrea
Copy link
Contributor

Hi @treydock, nothing related with your PR, thank you for submitting the PR!

@daianamezdrea daianamezdrea merged commit 7d3d1f5 into puppetlabs:main May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants