Support both standard Calico and Calico Tigera

[treydock]

#473 is not the right way to install Calico since the previous deployment method before that change was to deploy the on-premise YAML which installs the daemon sets to kube-system namespace which is still valid with all recent versions: https://docs.projectcalico.org/getting-started/kubernetes/self-managed-onprem/onpremises.

The Tigera install is documented as the "quickstart" method: https://docs.projectcalico.org/getting-started/kubernetes/quickstart but is not where close to what used to be previous behavior of this module.

If this solution of changing to using calico-tigera is not preferred let me know and I can adjust maybe to make the namespace dynamic. But the whole idea of modifying a file line from YAML is 100% not needed for on premise deployments of Calico which is the behavior that existed before #473

[puppet-community-rangefinder]

kubernetes::kube_addons is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[treydock]

@daianamezdrea Wanted to see if this change was acceptable in its current form?

[treydock]

I read more up on differences and looks like deploying calico.yaml is general purpose Calico, then if you want to install Calico through Tigera Operator you install that YAML file which is different but I believe it still installs what gets installed by calico.yaml. I think it's important to choose between the two because standard Calico is more straight forward and managed entirely differently than using Tigera Operator. If you download the release tar archive from Calico release pages, they contain both YAML where calico.yaml is standard install which this PR restores and then there is tigera-operator.yaml which is a different way to install and manage Calico.

[daianamezdrea]

Hi @treydock, sorry, we were on PTO last week on Community Day, let me have a look at your comments and find the best way here

[treydock]

@daianamezdrea Any chance to take a look at this? I think people are going to be a little surprised if they use Calico given the current behavior when compared to what Calico documents.

[daianamezdrea]

Hi @treydock, yes, I'll merge your PR and we can see how this evolve, thank you !