Skip to content

Conversation

ZloeSabo
Copy link
Contributor

The currently hardcoded parameters for the number of tries and sleep duration work for most setups. However, in some slower environments (like Vagrant), 30 sec is not enough to create a service account.

This change allows configuring $wait_for_default_sa_tries and $wait_for_default_sa_try_sleep so that they could be adjusted to a particular situation if needed.

@ZloeSabo ZloeSabo requested a review from a team as a code owner May 19, 2021 14:13
@CLAassistant
Copy link

CLAassistant commented May 19, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::wait_for_default_sa is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@carabasdaniel
Copy link
Contributor

Hi @ZloeSabo,

Thanks for your contribution, this looks great.

@carabasdaniel carabasdaniel merged commit d0f24f9 into puppetlabs:main May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants