Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for kubernetes dashboard version 2.0.0 and onwards #528

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

danifr
Copy link
Contributor

@danifr danifr commented Jul 13, 2021

Fix for #421

The URL changed after v2.0.0 this is why it was not working.

This patch is backwards compatible in case someone still wants to use old versions of the dashboard.

Thanks.

@danifr danifr requested a review from a team as a code owner July 13, 2021 17:21
@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::kube_addons is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@daianamezdrea
Copy link
Contributor

Hi @danifr, this looks good, thank you for opening the PR! Cheers !

@daianamezdrea daianamezdrea merged commit 0d16e90 into puppetlabs:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants