Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debian-family docker repo location and key id #535

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

jorhett
Copy link
Contributor

@jorhett jorhett commented Nov 28, 2021

Fix the docker apt repo the module tries to use, which currently produces the following error:

Error: /Stage[main]/Kubernetes::Repos/Apt::Source[docker]/Apt::Key[Add key: 58118E89F3A912897C070ADBF76221572C52609D from Apt::Source docker]/Apt_key[Add key: 58118E89F3A912897C070ADBF76221572C52609D from Apt::Source docker]/ensure: change from 'absent' to 'present' failed: Could not set 'present' on ensure: could not resolve https://apt.dockerproject.org/gpg (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/key.pp, line: 55)

apt.dockerproject.org no longer exists, dns name not found. It was shut down 03/31/2020.
Details of this change at https://www.docker.com/blog/changes-dockerproject-org-apt-yum-repositories/

@jorhett jorhett requested a review from a team as a code owner November 28, 2021 04:54
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

kubernetes::repos is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Change location to Docker official repo
Change to new apt repo's key fingerprint
Fix repo name to just the codename (no 'ubuntu-' prefix)
Change docker version to current kubernetes dependency recommendation
  https://github.com/kubernetes/kubernetes/blob/master/build/dependencies.yaml#L56-L58
@daianamezdrea
Copy link
Contributor

Hi @jorhett, this looks good, thank you!

@daianamezdrea daianamezdrea reopened this Nov 29, 2021
@daianamezdrea daianamezdrea merged commit d207df8 into puppetlabs:main Nov 29, 2021
@puppet-community-rangefinder
Copy link

kubernetes is a class

that may have no external impact to Forge modules.

kubernetes::repos is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jorhett jorhett deleted the fix_apt_repo branch December 7, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants