Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #541 #542

Merged
Merged

Conversation

nickperry
Copy link
Contributor

This fixes #541

@nickperry nickperry requested a review from a team as a code owner December 18, 2021 13:26
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nperry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puppet-community-rangefinder
Copy link

kubernetes::config::kubeadm is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

…cheduler_merged_extra_arguments. Revert to using scheduler_extra_arguments rather than scheduler_merged_extra_arguments in the config_kubeadm v1beta1 and v1beta2 templates. This fixes puppetlabs#541
@nickperry nickperry force-pushed the fix-issue-541-scheduler-crash-loop branch from 017fc06 to d5004b2 Compare December 18, 2021 14:31
@daianamezdrea
Copy link
Contributor

Hi @nickperry, can you sign the CLA, please? Thank you!

@nickperry
Copy link
Contributor Author

Hi @nickperry, can you sign the CLA, please? Thank you!

I have done previously. I signed it again a couple of days ago but it keeps resetting. Not sure what I can do.

@github-actions
Copy link

github-actions bot commented May 9, 2022

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label May 9, 2022
@chelnak chelnak removed the stale label May 9, 2022
@chelnak chelnak merged commit c746d5e into puppetlabs:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-scheduler is in a crash-loop when cloud_provider is set
5 participants