Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changing bits used for generating certificates #566

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

deric
Copy link
Collaborator

@deric deric commented Jul 20, 2022

Add possibility to change in kubetool number of bits used for generating certificates.

@deric deric requested a review from a team as a code owner July 20, 2022 07:47
@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

This module is declared in 0 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jordanbreen28
Copy link
Contributor

@deric Thanks for this. Looks like we will need you to rebase with main before we can proceed.

@deric
Copy link
Collaborator Author

deric commented Sep 26, 2022

@jordanbreen28 Rebased.

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jordanbreen28 jordanbreen28 merged commit 45ff100 into puppetlabs:main Sep 26, 2022
@deric deric deleted the key_size branch December 8, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants