(CLOUD-1701) Add path attribute to execs in kube_addons #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, puppet agent runs on a controller would fail because there is a relative path used in the assign master role and taint master node execs. These paths are present in the resource default, but that is contained within the bootstrap-controller conditional and thus not available for controllers. This patch moves the resource default above the conditional so it is present for both.
abottchen
force-pushed
the
cloud-1701-add-path-to-execs
branch
from
8ec1802
to
120afa2
Compare
|
LGTM |
lionce
pushed a commit
to lionce/puppetlabs-kubernetes
that referenced
this pull request
Dec 19, 2019
(maint) - Formatting test output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, puppet agent runs on a controller would
fail because there is a relative path used in the assign master role
and taint master node execs. These paths are present in the
resource default, but that is contained within the bootstrap-controller
conditional and thus not available for controllers. This patch moves
the resource default above the conditional so it is present for both.