Hardening manifest classes #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit some commands in our manifest classes would not be up to our code standards. This commit aims to sanitise our code a bit.
Prior to this commit, some test define classes test cases would not work as a result of the previous work (commands being separated into segments and being shell escaped). This commit aims to fix certain test cases so that they account for the newly implemented changes.
kubernetes::kube_addons is a classthat may have no external impact to Forge modules. kubernetes::kubeadm_init is a typethat may have no external impact to Forge modules. kubernetes::kubeadm_join is a typethat may have no external impact to Forge modules. kubernetes::packages is a classthat may have no external impact to Forge modules. kubernetes::service is a classthat may have no external impact to Forge modules. kubernetes::wait_for_default_sa is a typethat may have no external impact to Forge modules. This module is declared in 0 of 579 indexed public
|
Closed
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit some commands in our manifest classes would not be up to our code standards.
This commit aims to sanitise our code according to our teams best practices.