(CONT-217) Correct Kubernetes etcd_data_dir spec tests #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes::config::kubeadm is a classthat may have no external impact to Forge modules. This module is declared in 0 of 579 indexed public
|
GSPatton
force-pushed
the
correct-etcd_data_dir-spec-tests
branch
from
1bff7fe
to
38e28a1
Compare
|
spec test and integration test failures are the same failures seen in previous tests so are not related to this PR |
GSPatton
force-pushed
the
correct-etcd_data_dir-spec-tests
branch
from
38e28a1
to
418c681
Compare
Removed incorrect functionality and test cases. Added spec test to ensure that ETCD_DATA_DIR exists in the config file generated and ensures the default value of etcd_data_dir is its value Added spec tests to ensure the value of ETCD_DATA_DIR in the config file updates successfully when given various values of etcd_data_dir Fixed lint and Rubocop issues
GSPatton
force-pushed
the
correct-etcd_data_dir-spec-tests
branch
from
418c681
to
6db7e2a
Compare
chelnak
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed incorrect functionality and test cases.
Added spec test to ensure that ETCD_DATA_DIR exists in the config file generated and ensures the default value of etcd_data_dir is its value
Additional tests will come with CONT-215