Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build docker image tooling #589

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

BaronMsk
Copy link
Contributor

@BaronMsk BaronMsk commented Nov 7, 2022

Fix Build docker image tooling
Now, the build of the image is broken https://github.com/puppetlabs/puppetlabs-kubernetes/actions/runs/3406639576/jobs/5665490029#step:15:31
I'm making a docker image build fix

Prior to this commit, testing could not be executed due to docker failures.

This commit resolves the docker failures and allows the tests to proceed.

@BaronMsk BaronMsk requested a review from a team as a code owner November 7, 2022 12:54
@GSPatton
Copy link
Contributor

GSPatton commented Nov 7, 2022

Hi @BaronMsk. Could you update your description to fully explain the intent of this PR and the problem it aims to solve? Thanks

@BaronMsk
Copy link
Contributor Author

BaronMsk commented Nov 7, 2022

@GSPatton Now, the build of the image is broken https://github.com/puppetlabs/puppetlabs-kubernetes/actions/runs/3406639576/jobs/5665490029#step:15:31
I'm making a docker image build fix

Copy link
Contributor

@pmcmaw pmcmaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, we really appreciated it! :-)

@pmcmaw pmcmaw merged commit cf32e3c into puppetlabs:main Nov 15, 2022
@pmcmaw pmcmaw added the bugfix label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants