New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MAINT) Fixing codebase hardening issues #590

Merged

pmcmaw merged 1 commit into main from maint-codebase_hardening_bugfix

Nov 25, 2022

Contributor

LukasAud commented Nov 16, 2022 •

edited

Loading

Prior to this commit, an issue arised for Kubernetes that confirmed some code regressions within the module after the Codebase Hardening update (CONT-8). After investigating the resulting regression, some errors in the sanitisation process were spotted.

This PR aims to address these errors produced during the hardening stage before properly investigating and addressing the current regression (CONT-272).

Note: This PR will initially be categorised as maintenance. However, it might be related to both CONT-272 / #585 and CONT-263.


          (MAINT) Fixing codebase hardening issues

7d2eb4c

Prior to this commit, an issue arised for Kubernetes that confirmed some
code regressions within the module after the Codebase Hardening update
(CONT-8). After investigating the resulting regression, some errors in
the sanitisation process were spotted.

This PR aims to address these errors produced during the hardening stage
before properly investigating and addressing the current regression
(CONT-272).

Note: This PR will initially be categorised as maintenance. However, it
might be related to both CONT-272 and CONT-263.

LukasAud requested a review from a team as a code owner

November 16, 2022 12:13

puppet-community-rangefinder bot commented Nov 16, 2022

kubernetes::kube_addons is a class

that may have no external impact to Forge modules.

kubernetes::kubeadm_init is a type

that may have no external impact to Forge modules.

kubernetes::kubeadm_join is a type

that may have no external impact to Forge modules.

kubernetes::packages is a class

that may have no external impact to Forge modules.

kubernetes::wait_for_default_sa is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

LukasAud added bugfix maintenance backwards-incompatible and removed maintenance bugfix labels

Contributor Author

LukasAud commented Nov 22, 2022

Credits to ArsenyBelorukov for pointing out that our node_name regex check needed some updating to be more comprehensive and for providing an example.

Contributor

pmcmaw commented Nov 25, 2022

Merging, there are currently issues with our testing infrastructure and is something that we have noted and plan on addressing as soon as we possibly can. Changes in this PR address issues introduced by #575

pmcmaw merged commit 8ce4405 into main

pmcmaw deleted the maint-codebase_hardening_bugfix branch

November 25, 2022 11:30

LukasAud mentioned this pull request

Module not work #585

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatible