Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite command line arguments parsing #593

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

deric
Copy link
Collaborator

@deric deric commented Dec 8, 2022

Use less code to do the same thing. Arguments are defined in one place and can be read from ENV without using bash script to translate ARGS.

  • Upgraded Ruby base image
  • Fixed insecure CA algorithm
  • Short options remained the same:
usage: /etc/k8s/kube_tool.rb [options]
    -o, --os                    The OS that Kubernetes will run on
    -v, --version               The Kubernetes version to install
    -r, --container_runtime     The container runtime to use. This can only be "docker" or "cri_containerd"
    -c, --cni_provider          The networking provider to use, flannel, weave, calico, calico-tigera or cilium are supported
    -p, --cni_provider_version  The networking provider version to use, calico and cilium will use this to reference the correct deployment download link
    -t, --etcd_ip               The IP address etcd will listen on
    -i, --etcd_initial_cluster  The list of servers in the etcd cluster
    -a, --api_address           The IP address (or fact) that kube api will listen on
    -b, --key_size              Specifies the number of bits in the key to create
    -d, --install_dashboard     Whether install the kube dashboard
    -h, --help                  print the help

After upgrading the golang base image #589, the cloudflare/cfssl doesn't have fixed version and might eventually break with any breaking change. Currently generating CA certificates is broken.

Use less code to do the same thing. Allow reading arguments from ENV
variables.
RSA 2048 is considered too weak for CA cert
@chelnak chelnak merged commit cc6cd96 into puppetlabs:main Dec 14, 2022
@chelnak chelnak self-assigned this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants