Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding containerd socket path (#596) #597

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

deric
Copy link
Collaborator

@deric deric commented Dec 10, 2022

This commits reverts changes done in cfbd9de (#576) while allowing overriding socket path via kubernetes::containerd_socket parameter.

The address unix:///run/containerd/containerd.sock doesn't seem to be supported by all containerd versions.
cc @chelnak
Fixes #596.

This commits reverts changes done in cfbd9de
while allowing overriding socket path via kubernetes::containerd_socket
parameter.
@deric deric requested a review from a team as a code owner December 10, 2022 13:20
@puppet-community-rangefinder
Copy link

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

kubernetes::packages is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@chelnak chelnak merged commit 57eed28 into puppetlabs:main Dec 10, 2022
@chelnak
Copy link
Contributor

chelnak commented Dec 10, 2022

Just for reference, i've pulled these changes in to my branch and everything seems tip top.

image

@deric deric deleted the containerd_socket branch December 12, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerd won't bind GRPC endpoint
3 participants