Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix executing CNI addons commands (fixes #594) #598

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Conversation

deric
Copy link
Collaborator

@deric deric commented Dec 10, 2022

This PR attempts to fix some changes introduced in #592 and #575.

  • Wrap commands in single array
  • Don't use double quotes for strings where string interpolation isn't needed
  • Avoid unnecessary code duplication

The exec containing command in form

['kubectl', 'get', 'nodes']

will print help message to stdout instead of executing kubectl get nodes.

Wrap commands in single array, don't use double quotes for strings
where string interpolation isn't needed. Avoid unnecessary code
duplication.
@deric deric requested a review from a team as a code owner December 10, 2022 15:59
@puppet-community-rangefinder
Copy link

kubernetes::kube_addons is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

manifests/kube_addons.pp Outdated Show resolved Hide resolved
manifests/kube_addons.pp Outdated Show resolved Hide resolved
Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It goes further than my branch right now because you are addressing test issues too.

I have left a couple of comments that I'd like you to address before we merge.

Copy link
Contributor

@chelnak chelnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @deric

@chelnak chelnak merged commit 895b6ed into puppetlabs:main Dec 12, 2022
@chelnak chelnak added the bug label Dec 12, 2022
@deric deric deleted the exec branch December 12, 2022 12:52
@deric deric mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants