(maint) Fix some typos in the readme #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccaum
suggested changes
Mar 3, 2018
There was a problem hiding this comment.
This is great! Thanks, @lucywyman! If you could just remove the link added to line 44 for kubetool, then this is good to go from my perspective.
README.md
Outdated
| all the security parameters, the bootstrap token, and other configurations for | ||
| your Kubernetes cluster into a Hiera file. The tool is available as a Docker | ||
| This module includes a configuration tool called | ||
| [kubetool](https://github.com/abema/kubetool) to auto generate all the security |
There was a problem hiding this comment.
Not that kubetool :)
Our kubetool is specific to the module and in the tooling/kube_tool directory.
lucywyman
force-pushed
the
maint-update-readme
branch
from
c904d10
to
7f8d28f
Compare
|
Oh my goodness, I completely forgot about this! Apologies! @ccaum fixed :) |
|
Oh wow I forgot about this too. Thanks @lucywyman! @davejrt or @scotty-c, LGTM. Can you merge? |
|
LGTM |
lionce
pushed a commit
to lionce/puppetlabs-kubernetes
that referenced
this pull request
Dec 19, 2019
Use https instead of ssh for the clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.