Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing taint and label to fqdn #73

Merged
merged 1 commit into from Mar 5, 2018
Merged

changing taint and label to fqdn #73

merged 1 commit into from Mar 5, 2018

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Mar 5, 2018

fixes #60

Where a node has a FQDN, this will allow the role/taint to be applied correctly. Where the shortname and FQDN are the same, this will also work without issue.

@davejrt davejrt requested a review from scotty-c March 5, 2018 02:26
@scotty-c
Copy link
Contributor

scotty-c commented Mar 5, 2018

LGTM

@scotty-c scotty-c merged commit 324f32f into master Mar 5, 2018
@scotty-c scotty-c deleted the CLOUD-1731 branch March 5, 2018 04:46
davejrt added a commit that referenced this pull request Mar 5, 2018
davejrt pushed a commit that referenced this pull request Mar 8, 2018
devcfgc pushed a commit to ve-global/puppetlabs-kubernetes that referenced this pull request Mar 16, 2018
@davejrt davejrt added this to the 1.1.0 milestone Apr 15, 2018
lionce pushed a commit to lionce/puppetlabs-kubernetes that referenced this pull request Dec 19, 2019
(MODULES-8181) - Release Prep for 0.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FQDN / shortname mismatch
2 participants