-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin versions of debian packages #86
Conversation
…_package_version`.
|
@admont This PR looks good. The only thing we did is actually not add the Docker version as a param. Only that it could allow a user to run a version of Docker that has not been verified by the Kubernetes project. Which could cause support issues on our side. The idea behind hardcoding the version was to allow us to test the version of Docker that works with the widest range of Kubernetes versions. What value would the end user get from adding the Docker version as a param? |
|
I see a few reasons. At a moment current versions are: K8s - v1.9.2, Docker - v.1.12.0-x, K8s Puppet module - v1.0.3.
|
865845f
to
f5633c3
Compare
|
Rebase is done |
|
@admont I will check this out in the next 24 hours |
|
Thanx! |
|
@scotty-c any news? |
|
@admont I will have a look at this one tomorrow. Sorry I have been in transit from Sydney to Belfast |
|
@admont Thanks for a great PR |
|
Thanx! |
(MODULES-8587) Release prep 0.4.0
docker-engine,kubelet,kubectlandkubernetes-cnipackages.