Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin versions of debian packages #86

Merged
merged 19 commits into from
Apr 17, 2018

Conversation

admont
Copy link
Contributor

@admont admont commented Mar 26, 2018

  • Pin versions of docker-engine, kubelet, kubectl and kubernetes-cni packages.
  • Parametrize CNI and Docker package names and versions.
  • Cover with unit tests.
  • Update documentation.

@scotty-c
Copy link
Contributor

@admont This PR looks good. The only thing we did is actually not add the Docker version as a param. Only that it could allow a user to run a version of Docker that has not been verified by the Kubernetes project. Which could cause support issues on our side. The idea behind hardcoding the version was to allow us to test the version of Docker that works with the widest range of Kubernetes versions. What value would the end user get from adding the Docker version as a param?

@admont
Copy link
Contributor Author

admont commented Mar 27, 2018

I see a few reasons. At a moment current versions are: K8s - v1.9.2, Docker - v.1.12.0-x, K8s Puppet module - v1.0.3.

  1. Lets say with Puppet module v1.1.0 you are going to upgrade K8s to v1.10.0 and Docker to v.1.13.0-x. But also you fix some bugs and bring new futures. So users would like to have the new version but enterprise users usually prefer to stay with older versions of software - K8s, Docker, CNI, etc.
  2. Lets say Debian release a new version of Docker package v.1.12.0-y in some reason. Which doesn't work correctly in users environment. Until Debian release another version of package with fix user most likely prefer to stay with v.1.12.0-x.
  3. In some reason user prefer to stay with Docker version v.1.12.0-x but with new K8s version, maybe because of application implementation or CI tools.

@scotty-c
Copy link
Contributor

scotty-c commented Apr 5, 2018

@admont would you please rebase this PR against master due to merging #82
Thanks in advance

@admont
Copy link
Contributor Author

admont commented Apr 10, 2018

Rebase is done

@scotty-c
Copy link
Contributor

@admont I will check this out in the next 24 hours

@admont
Copy link
Contributor Author

admont commented Apr 11, 2018

Thanx!
Back to question regarding docker version as a parameter. According K8s documentation the validated docker versions are 1.11.2 to 1.13.1 and 17.03.x. So it is not one binded version. Any way #82 already have docker version as parameter.

@admont
Copy link
Contributor Author

admont commented Apr 16, 2018

@scotty-c any news?

@scotty-c
Copy link
Contributor

@admont I will have a look at this one tomorrow. Sorry I have been in transit from Sydney to Belfast

@scotty-c
Copy link
Contributor

@admont Thanks for a great PR

@scotty-c scotty-c merged commit 788db6d into puppetlabs:master Apr 17, 2018
@admont
Copy link
Contributor Author

admont commented Apr 17, 2018

Thanx!

@admont admont deleted the feature/control_dpkgs branch April 17, 2018 12:59
lionce pushed a commit to lionce/puppetlabs-kubernetes that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants