Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-lvm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.1
Choose a base ref
...
head repository: puppetlabs/puppetlabs-lvm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.2
Choose a head ref
  • 18 commits
  • 27 files changed
  • 7 contributors

Commits on Aug 14, 2012

  1. Updated Modulefile & README for 0.1.1

    Ryan Coleman committed Aug 14, 2012
    Configuration menu
    Copy the full SHA
    a1eb550 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #13 from rcoleman/bugs/0.1.1_release

    Updated Modulefile & README for 0.1.1
    haus committed Aug 14, 2012
    Configuration menu
    Copy the full SHA
    3b1f783 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2013

  1. Fix undefined method: inject for String

    The physical_volumes extraction using inject function doesn't work.
    Change to using split/grep/map.
    
    /Stage[main]/Releng::Disks/Volume_group[vg] (err): Could not evaluate: undefined method `inject' for "  PV,VG\n/dev/sda4,vg\n":String
    
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
    robbat2 committed Jan 11, 2013
    Configuration menu
    Copy the full SHA
    95cecec View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2013

  1. Merge pull request #20 from gentoo/master

    Fix undefined method: inject for String
    adrienthebo committed Jan 18, 2013
    Configuration menu
    Copy the full SHA
    b831542 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2013

  1. use command 'blkid' instead of 'mount' to check the filesystem type

    The options "--guess-fstype" was removed from the mount command [1].
    Commands "fsck -N" and "file -sL" were also tested but their output are
    not consitent between filesystems. 'blkid' finally seems to be the best candidate
    to replace 'mount' and this utility is also present in the standard
    package util-linux.
    
    This patch fix the following bug https://projects.puppetlabs.com/issues/19410
    
    [1] http://git.kernel.org/?p=utils/util-linux/util-linux.git;a=commit;h=0377ef91270d06592a0d4dd009c29e7b1ff9c9b8
    mbornoz committed Feb 26, 2013
    Configuration menu
    Copy the full SHA
    98e7061 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2013

  1. Merge pull request #23 from mbornoz/master

    use 'blkid' instead of 'mount' to check the filesystem type
    Ryan Coleman committed Feb 28, 2013
    Configuration menu
    Copy the full SHA
    9c55366 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2013

  1. (maint) rename spec files

    The common convention for naming spec files is ${tested_file}_spec.rb,
    and running the `rspec` command will run all accordingly named files.
    This commit renames all existing spec files to conform to this
    convention.
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    c43a2fa View commit details
    Browse the repository at this point in the history
  2. (maint) simplify rspec spec_helper.rb require

    With rspec 2 simply doing `require 'spec_helper'` will bring in the
    project spec helper. This commit removes the existing complex require
    logic with a simple require statement.
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    57c694a View commit details
    Browse the repository at this point in the history
  3. (maint) use 2 space indentation for spec files

    All of the spec files were using 4 space indents. This commit changes
    the indentation to the standard 2 space indent that's the common
    convention in the ruby community.
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    6baf3af View commit details
    Browse the repository at this point in the history
  4. (maint) add Gemfile

    This commits a basic Gemfile to allow for easier testing. It respects
    the environment variable 'PUPPET_GEM_VERSION' in cases where the module
    needs to be tested with multiple versions of Ruby.
    adrienthebo committed Mar 8, 2013
    3 Configuration menu
    Copy the full SHA
    b569417 View commit details
    Browse the repository at this point in the history
  5. (maint) add .travis.yml configuration

    This commit adds configuration for travis-ci to test this module against
    supported versions of puppet. It also suppresses emails on
    travis builds.
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    4da6ff0 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'maint-cleanup_spec_files'

    This closes GH-21 and GH-22
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    a5ac5a5 View commit details
    Browse the repository at this point in the history
  7. (maint) Add Rakefile

    This rakefile is needed to drive travis-ci tests.
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    22fbd01 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d2505ed View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5c668e3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d19dde9 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #26 from rharrison10/cleanup

    Move volume define to the correct location in the autoload module layout
    adrienthebo committed Mar 8, 2013
    Configuration menu
    Copy the full SHA
    a1300c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2013

  1. Update metadata for 0.1.2 release

    This commit updates Modulefile for a 0.1.2 release. 0.1.2 represents
    a bug-fix release that is mostly focussed on testing improvements
    but includes a few important fixes.
    Ryan Coleman committed Mar 18, 2013
    Configuration menu
    Copy the full SHA
    fa219cb View commit details
    Browse the repository at this point in the history
Loading