Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-lvm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-lvm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.1
Choose a head ref
  • 13 commits
  • 8 files changed
  • 8 contributors

Commits on Jul 10, 2017

  1. Added Hash as acceptable type for physical_volumes 

    The line 11 checks if is_hash and that condition can't apply if the only acceptable type are Array and String
The error I got and that is fixed is:
parameter 'physical_volumes' expects a value of type Array or String, got Struct at ...
    @stivesso
    stivesso authored Jul 10, 2017
    Configuration menu
    Copy the full SHA
    49ec797 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2017

  1. Don't execute the lvm commands when not supported. 

    When lvm_support was not present, facter would still attempt to execute
the vgs and pvs commands.
    @smithj4
    smithj4 committed Sep 12, 2017
    Configuration menu
    Copy the full SHA
    35cf8a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2017

  1. Merge pull request #196 from puppetlabs/release 

    Release mergeback
    willmeek authored Nov 9, 2017
    Configuration menu
    Copy the full SHA
    048d084 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2017

  1. Merge pull request #193 from smithj4/patch-1 

    Don't execute the lvm commands when not supported.
    @pmcmaw
    pmcmaw authored Nov 24, 2017
    Configuration menu
    Copy the full SHA
    5e1279b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. #puppethack Fix error when creating XFS on top of another Filesystem 

    #puppethack: This is to fix the Lvm generated error when creating xfs on top of existing filesystem (returned 1: mkfs.xfs: /dev/mapper/myvg-mylv appears to contain an existing filesystem (ext4)).
    @stivesso
    stivesso authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    d439357 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #200 from stivesso/patch-2 

    #puppethack Fix error when creating XFS on top of another Filesystem
    @pmcmaw
    pmcmaw authored Dec 7, 2017
    Configuration menu
    Copy the full SHA
    7c66f6e View commit details
    Browse the repository at this point in the history

  3. Spelling 

    Fix minor spelling mistakes.
    @arjenz
    arjenz committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    7f05ea8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. (RE-9906) Migrate from stickler to artifactory

    @sarameisburger
    sarameisburger committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    cf61c5a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Merge pull request #203 from sarameisburger/master 

    (RE-9906) Migrate from stickler to artifactory
    @pmcmaw
    pmcmaw authored Jan 30, 2018
    Configuration menu
    Copy the full SHA
    71bbf45 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #201 from arjenz/patch-1 

    Spelling
    @pmcmaw
    pmcmaw authored Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9dbbb04 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. Merge pull request #189 from stivesso/patch-1 

    Added Hash as acceptable type for physical_volumes
    @hunner
    hunner committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    4655120 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. (MODULES-7070) - 1.0.1 Release prep

    @pmcmaw
    pmcmaw committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    5e55c06 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #207 from pmcmaw/release_prep 

    (MODULES-7070) - 1.0.1 Release prep
    Helen authored Apr 26, 2018
    Configuration menu
    Copy the full SHA
    e2b34a3 View commit details
    Browse the repository at this point in the history
Loading