Fix bad regexp #108
Merged
Fix bad regexp #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting this, could you add a test to reflect the problem seen. This will prevent the issue from resurfacing. |
|
test added. |
|
Sorry, i think the unit tests are failing. |
|
Sorry - I didn't realize you were supporting ruby 1.8.7. I'll switch to using hash rockets in the patch. |
* regular expression was incorrectly using character classes and matching strings like: 100( or 100v etc. * added unit test
|
What's the good word on this? :-) |
|
Sorry about the delay, thanks for the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regular expression was incorrectly using character classes and matching strings like: 100( or 100v etc.