(MODULES-2103) Adds RAL for volume group #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| describe 'self.instances' do | ||
| before :each do | ||
| @provider.class.stubs(:vgs).returns(lvs_output) |
There was a problem hiding this comment.
Looks like this should be vgs_output
There was a problem hiding this comment.
Gah, too much copypasta
|
Hey @petems , other than the test failure this looks good, just let me know when you have that fixed. Thanks! |
petems
force-pushed
the
MODULES-2103-add_RAL_for_volume_group
branch
from
4967ea2
to
9b8d64b
Compare
|
@mhaskel Fixed! 😄 |
underscorgan
pushed a commit
that referenced
this pull request
Jun 22, 2015
…roup (MODULES-2103) Adds RAL for volume group
|
👍 thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
…r_volume_group (MODULES-2103) Adds RAL for volume group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.