Added support for volumes not mounted by lvm. #127
Conversation
|
Thanks for the contribution @polpot78! This is a great feature for the logical volume defined type. Is it possible for you to add a description to the README as well as a quick unit test testing the new parameter? |
|
I have added a simple test and a little bit documentation. Is it ok now? |
| @@ -164,6 +164,7 @@ resources out yourself. | |||
| - `:core` | |||
| - `:disk` | |||
| - `:mirrored` | |||
| * monted - If puppet should mount the volume. This only affects what puppet will do, and not what will be mounted at boot-time. | |||
There was a problem hiding this comment.
Fixed
On ti., 2015-12-15 at 11:16 -0800, Bryan Jen wrote:
In README.md:
@@ -164,6 +164,7 @@ resources out yourself.
-:core
-:disk
-:mirrored
+* monted - If puppet should mount the volume. This only affects
what puppet will do, and not what will be mounted at boot-time.
mounted
—
Reply to this email directly or view it on GitHub.
|
Yep! Looks great @polpot78! If you can squash the commits, I can merge this. Thanks! |
kny78
force-pushed
the
master
branch
2 times, most recently
from
b0e021b
to
b5ba870
Compare
|
Done
|
Added support for volumes not mounted by lvm.
This patch allows a logical_volume to be made ready, but not mounted.
This allows for the actual mount to be done after data is migrated to the new volume.