Added the createonly option for the volumegroup and the possibility t… #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o give more information for the PV
|
ETA on merge? |
|
Thanks @ricciocri ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
Added the createonly option for the volumegroup and the possibility t…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o give more information for the PV.
In our infrastructure we have some highlevel configuration in hiera (our global.yaml) that is read via a hiera_hash (with deep merge) by all nodes, this is useful to have all the disk with the same setup.
But we have some exception and so to manage "easily" them we added the option createonly to the define lvm::volume_group, while working on this we found useful to give more information about the physical volumes as well, so we added a new define and the possibility to use an hash to pass more information to the define lvm::volume_grop.
Compatibility with the old configuration is mantained, so if physical_volume it's an array nothing change from the past behaviour.
Changed the README to show these changes as well.