(MODULES-3230) Add flag to Logical_volume to not resize filesystem #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix the failing test and also add new tests for this. |
|
Tests added |
| xfs_growfs( path) || fail( "Cannot resize filesystem to size #{new_size} because xfs_growfs failed." ) | ||
| elsif blkid_type =~ /\bTYPE=\"(swap)\"/ | ||
| swapoff( path) && mkswap( path) && swapon( path) || fail( "Cannot resize swap to size #{new_size} because mkswap failed." ) | ||
| unless @resource[:resize_fs] == :false or @resource[:resize_fs] == false or @resource[:resize_fs] == 'false' |
There was a problem hiding this comment.
One ruby shortcut for this is unless [false, :false, 'false'].include?(@resource[:resize_fs])
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently changing the size of a logical volume using the lvm provider on our Xen dom0 causes issues for us because the volume is exposed to a vm and is mounted there but the volume does not appear mounted to the host. Therefore, resize2fs tries to do an offline resize on the volume which causes issues. This adds a "resize_fs" flag to the logical_volume type that, when set to false, will not attempt that resize.