resolve /dev/disk/by-path/xxxx symlinks to block devices #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase, this is why travisCI maybe failing for this PR. I tested this with #168 |
|
Could the commits be squashed? Also please include "(MODULES-3991)" at the beginning of the commit message for future tracking. |
…symlinks to real devices, and override insync? method to do this
|
These tests pass if I change the version of rspec to ~> 3.4.0. |
|
Thanks @timhughes and @lukebigum ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new parameter to tell volume_group Type to resolve PV symlinks to real devices, and override insync? method to do this