[#puppethack] fix syntax error in volume.pp #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue MODULES-4172. Syntax error (using "+" with string) in fail message of volume.pp. + replaced with sprintf for concatantion error string.
eputnam
requested changes
Dec 13, 2016
| @@ -137,8 +137,8 @@ | |||
|
|
|||
| } | |||
| default: { | |||
| fail ( 'puppet-lvm::volume: ensure parameter can only be set to ' + | |||
| 'cleaned, absent or present' ) | |||
| fail ( sprintf("%s%s", 'puppet-lvm::volume: ensure parameter can only ', | |||
There was a problem hiding this comment.
Rake is throwing a fit but locally the only thing lint complains about is the double quotes here. If you could just change those to single I think we'll be good to go.
in volume.pp changed the double qoutes to single quotes
eputnam
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue MODULES-4172.
Syntax error (using "+" with string) in fail message of volume.pp.