New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting thinpool default to false #182

Merged

eputnam merged 1 commit into puppetlabs:master from missingcharacter:patch-1

Mar 9, 2017

Contributor

missingcharacter commented Mar 8, 2017

According to docs https://github.com/puppetlabs/puppetlabs-lvm/blob/master/README.md, thinpool is default to false, but as we see in https://github.com/puppetlabs/puppetlabs-lvm/blob/master/manifests/logical_volume.pp#L24 it is default to undef and then it is always called in https://github.com/puppetlabs/puppetlabs-lvm/blob/master/manifests/logical_volume.pp#L92


          Setting thinpool default to false

379a13c

According to docs https://github.com/puppetlabs/puppetlabs-lvm/blob/master/README.md, thinpool is default to false, but as we see in https://github.com/puppetlabs/puppetlabs-lvm/blob/master/manifests/logical_volume.pp#L24 it is default to undef and then it is always called in https://github.com/puppetlabs/puppetlabs-lvm/blob/master/manifests/logical_volume.pp#L92

Contributor

eputnam commented Mar 9, 2017

@missingcharacter thanks for the PR! Great catch.

eputnam merged commit d5dee32 into puppetlabs:master

missingcharacter deleted the patch-1 branch

March 10, 2017 16:36

jordanbreen28 added the bugfix label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels