Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confine lvm providers to linux (MODULES-6449) #205

Merged
merged 2 commits into from
Aug 17, 2018

Conversation

hpcprofessional
Copy link

No description provided.

@jessereynolds
Copy link

jessereynolds commented Mar 13, 2018

This module is unusable for any organisation that has any Windows machines managed by puppet, though I think the custom facts need to also be confined to kernel = linux.

@lesinigo
Copy link

lesinigo commented Apr 4, 2018

This is also causing Facter errors on FreeBSD which we didn't have when using version 0.9.0:

Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Facter: error while resolving custom facts in /var/puppet/lib/facter/lvm_support.rb: execution of command "vgs -o name --noheadings 2>/dev/null" failed: command not found.
Info: Applying configuration version '[63f1f3c] upgrade module puppetlabs/lvm (0.9.0 -> 1.0.0)'
Notice: Applied catalog in 1.93 seconds

@rodolfosalgado
Copy link

Any news when will this be merged ?

@daveseff
Copy link

daveseff commented Aug 9, 2018

+1

@HelenCampbell
Copy link

Thanks @hpcprofessional !

@HelenCampbell HelenCampbell merged commit 898a427 into puppetlabs:master Aug 17, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-lvm that referenced this pull request Jun 4, 2020
Confine lvm providers to linux (MODULES-6449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants