Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for LVM Thin Volumes #210

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Added support for LVM Thin Volumes #210

merged 2 commits into from
Jul 13, 2018

Conversation

glorpen
Copy link
Contributor

@glorpen glorpen commented Jun 23, 2018

No description provided.

@glorpen
Copy link
Contributor Author

glorpen commented Jul 2, 2018

Can someone look at this PR? I think it is simple enough change.

@glorpen
Copy link
Contributor Author

glorpen commented Jul 10, 2018

Can I interest you in this PR? :) @pmcmaw @willmeek

@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 10, 2018

Hey @glorpen

The change looks fine :-), would you be able to add some testing around the new functionality please :-)

@glorpen
Copy link
Contributor Author

glorpen commented Jul 10, 2018

I've added some tests. I've tried to make one for autorequire but... lack of knowledge about rspec stopped me.

@glorpen
Copy link
Contributor Author

glorpen commented Jul 11, 2018

@pmcmaw is it enough for tests?

@pmcmaw pmcmaw merged commit 120218a into puppetlabs:master Jul 13, 2018
@glorpen glorpen deleted the lvmthin branch July 14, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glorpen @pmcmaw @rgtx @jordanbreen28