Don't execute the lvm commands when not supported. #193 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately you've deleted the changes, merged in puppetlabs#193 with the new release 1.1.0. Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/cache/lib/facter/lvm_support.rb: execution of command "vgs -o name --noheadings 2>/dev/null" failed: command not found.
|
@dylanratcliffe is working on a fix in #220 IMHO, these facts should be obsoleted, new structured facts serve the same purpose in more modern way |
|
I vote we just merge this and do a separate PR for removing those facts with the next major release. Trying to make them work properly is barely worth it give that they are super old-school anyway |
|
Thanks for the fix @jonny0303, and the input @dylanratcliffe |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Jun 4, 2020
Don't execute the lvm commands when not supported. puppetlabs#193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately you've deleted the changes, merged in #193 with the new release 1.1.0.
Error: Facter: error while resolving custom facts in /opt/puppetlabs/puppet/cache/lib/facter/lvm_support.rb: execution of command "vgs -o name --noheadings 2>/dev/null" failed: command not found.