Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'blkid' instead of 'mount' to check the filesystem type #23

Merged
merged 1 commit into from
Feb 28, 2013

Conversation

mbornoz
Copy link
Contributor

@mbornoz mbornoz commented Feb 26, 2013

The options "--guess-fstype" was removed from the mount command [1].
Commands "fsck -N" and "file -sL" were also tested but their output are
not consitent between filesystems. 'blkid' seems to be the best candidate
to replace 'mount' and this utility is also present in the standard
package util-linux.

This patch fix the following bug https://projects.puppetlabs.com/issues/19410

[1] http://git.kernel.org/?p=utils/util-linux/util-linux.git;a=commit;h=0377ef91270d06592a0d4dd009c29e7b1ff9c9b8

The options "--guess-fstype" was removed from the mount command [1].
Commands "fsck -N" and "file -sL" were also tested but their output are
not consitent between filesystems. 'blkid' finally seems to be the best candidate
to replace 'mount' and this utility is also present in the standard
package util-linux.

This patch fix the following bug https://projects.puppetlabs.com/issues/19410

[1] http://git.kernel.org/?p=utils/util-linux/util-linux.git;a=commit;h=0377ef91270d06592a0d4dd009c29e7b1ff9c9b8
@mkrakowitzer
Copy link
Contributor

ty, works flawlessly.

@ryanycoleman
Copy link

Thank you!

ryanycoleman pushed a commit that referenced this pull request Feb 28, 2013
use 'blkid' instead of 'mount' to check the filesystem type
@ryanycoleman ryanycoleman merged commit 9c55366 into puppetlabs:master Feb 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants