Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/14718: size 'undef' doesn't work when creating a new logical volume #28

Merged
merged 2 commits into from
May 21, 2013

Conversation

raskas
Copy link
Contributor

@raskas raskas commented Mar 12, 2013

Code as provided by Sander Hollaar in http://projects.puppetlabs.com/issues/14718
Problem is also described in http://projects.puppetlabs.com/issues/17920

@puppetcla
Copy link

CLA Signed by raskas on 2011-12-01 21:00:00 -0800

@adrienthebo
Copy link
Contributor

Thank you for this contribution!

It appears that the Travis-ci tests are currently failing on this pull request. We're unable to merge pull requests with failing tests, so these need to be reviewed and resolved before we can proceed. The spec failure in question is https://travis-ci.org/puppetlabs/puppetlabs-lvm/jobs/5438436#L140 ; could you investigate this?

If you would like assistance with this, I would be happy to help. #puppet-dev on freenode would be the best place to get ahold of me; I'm generally available from 9:00 - 17:00 GMT -7, and my IRC handle is finch.

@raskas
Copy link
Contributor Author

raskas commented Mar 25, 2013

I fixed the test-case to represent my changes.
It now expects the --extents option when size is set to undef.

Build is now ok: https://travis-ci.org/puppetlabs/puppetlabs-lvm/builds/5773771

adrienthebo added a commit that referenced this pull request May 21, 2013
Feature/14718: size 'undef' doesn't work when creating a new logical volume
@adrienthebo adrienthebo merged commit 3e316ab into puppetlabs:master May 21, 2013
@adrienthebo
Copy link
Contributor

summary: merged into master in 3e316ab. Thanks for the contribution and sorry for the delay in getting this merged!

cegeka-jenkins pushed a commit to cegeka/puppet-lvm that referenced this pull request Oct 23, 2017
Feature/14718: size 'undef' doesn't work when creating a new logical volume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants