Allow for physical_volumes and volume_groups that change a system lives #30
Conversation
| lines.split(/\n/).grep(/,#{@resource[:name]}$/).map { |s| | ||
| if @resource[:createonly].to_s == "false" || ! vgs(@resource[:name]) | ||
| lines = pvs('-o', 'pv_name,vg_name', '--separator', ',') | ||
| lines.split(/\n/).grep(/,#{@resource[:name]}$/).map { |s| |
There was a problem hiding this comment.
For blocks that span more than one line, it's convention to use do/end. This could be refactored as follows:
lines.split(/\n/).grep(/,#{@resource[:name]}$/).map do |s|
s.split(/,/)[0].strip
endThere was a problem hiding this comment.
Oh, this is an existing behavior. Ah well, the point still stands, but don't feel compelled to change this. :)
|
It looks like this is failing in Travis-ci; could you take a look at that? Is https://travis-ci.org/puppetlabs/puppetlabs-lvm/jobs/6675203#L149 a valid failure? |
|
I can't tell why https://travis-ci.org/puppetlabs/puppetlabs-lvm/jobs/6675203#L149 is failing. (most likely do to my lack of experience with travis-ci). The change I made will bypass the pvs if the unlessvg option is set to a VG and the VG exists. Ok, figured it out, building new spec tests now. Thanks |
|
I'd love to see this merged into the LVM module. We also have this issue. I added another physical volume to one of our instances yesterday to extend a volume group and Puppet keeps complaining about it. |
| @resource.expects(:[]).with(:name).returns('/dev/sdb') | ||
| @provider.expects(:pvs).returns(true) | ||
| @provider.should be_exists | ||
| end | ||
| ### |
There was a problem hiding this comment.
Any chance I can get you to remove this spec test as it's not working?
|
Removed spec test that did not work from the code. |
Allow for physical_volumes and volume_groups that change a system lives
The issue being addressed is the change of a systems after it is provisioned. Sometimes you have to add disks or modify a server that makes it non standard. Usually this occurs on systems that have a large amount of data.
By adding the unless_vg (physical_volume) and createonly (volume_group) options you can have standard deployments and still support the non standard growth while using puppet-lvm.