[GH-298] fix lvm_vg_* facts

[rtib]

Summary

This is reverting 8e1e8eb and fixing the spec tests other way.

Additional Context

See issue #298

Related Issues (if any)

Closes #298 .

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• Manually verified. (For example puppet apply)

[CLAassistant]

All committers have signed the CLA.

[jordanbreen28]

Thanks for this and spotting my oversight @rtib!
The cancelling tests are expected and are on our radar right now, I'll update this and re-kick once this has been resolved.

[jordanbreen28]

@rtib can you rebase off of main?

[rtib]

Sure.

[jordanbreen28]

Pending tests

[rtib]

Some acceptance tests failed. The Debian-11, Puppet-8 test seems to have failed the tear down of the test VM, and the Ubuntu-20.04, Puppet-7 VM seems to fail provisioning. I assume these aren't connected to the changes in this PR.

[jordanbreen28]

Thanks for your work on this one @rtib!

[jordanbreen28]

Some acceptance tests failed. The Debian-11, Puppet-8 test seems to have failed the tear down of the test VM, and the Ubuntu-20.04, Puppet-7 VM seems to fail provisioning. I assume these aren't connected to the changes in this PR.

Yes seen that! I re-kicked and they passed.