use ensure_resources to handle multiple physical_volume in a volume_grou... #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup (dependency in Modulefile is only stdlib 2.x, although 4.1 is required for this new behaviour.)
| @@ -3,3 +3,4 @@ version '0.1.2' | |||
| license 'GPLv2' | |||
| summary 'Puppet types and providers to manage LVM' | |||
| project_page 'https://github.com/puppetlabs/puppetlabs-lvm' | |||
| dependency 'puppetlabs/stdlib', '>= 2.0' | |||
There was a problem hiding this comment.
If you require stdlib 4.1 as the comment here[1] then should read be
dependency 'puppetlabs/stdlib', '4.1.x'
|
thanks for looking at my patch. I was in two minds about this since I didn't want to make puppetlabs-lvm unavailable to those running older Puppet versions (like ourselves... I just copied the newer ensure_resources.rb into our stdlib 2.x branch), for a feature they don't necessarily need. |
|
I'm torn on this, I feel like there's -always- a way to restructure things to avoid ensure_resources or defined in the first place. Let me think on this and take a look at the code, see if I can think of an alternative. |
|
Who am I kidding, I sure didn't make anything better here. |
apenney
pushed a commit
that referenced
this pull request
Jan 24, 2014
use ensure_resources to handle multiple physical_volume in a volume_grou...
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
use ensure_resources to handle multiple physical_volume in a volume_grou...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...p
(dependency in Modulefile is only stdlib 2.x, although 4.1 is required
for this new behaviour.)