Suppress facter warnings on systems that don't support LVM. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| confine :kernel => :linux | |||
|
|
|||
| setcode do | |||
| vgdisplay = Facter::Util::Resolution.exec('which vgs') | |||
| vgdisplay = Facter::Util::Resolution.exec('which vgs 2>/dev/null') | |||
There was a problem hiding this comment.
Can you give this a test with:
vgdisplay = Facter::Util::Resolution.which('vgs')
As we have a helper for which already. :)
|
I updated the pull request to use the builtin which instead of exec and tested on our hosts. |
|
Unfortunately this breaks the tests! https://travis-ci.org/puppetlabs/puppetlabs-lvm/jobs/12899316 Can you take a quick look? It should be as simple as updating it to use .which instead of .exec, just like the fact change. (Once that's fixed can you rebase everything to a single commit for clean merging?) |
|
Pull request updated to pass CI tests and commits squashed. |
apenney
pushed a commit
that referenced
this pull request
Oct 23, 2013
Suppress facter warnings on systems that don't support LVM.
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
Suppress facter warnings on systems that don't support LVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing these facter warnings when running puppet on our systems that don't use LVM:
/usr/bin/which: no vgs in (/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin)