Added Parameter 'size_is_minsize' (true|false(default)) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally enlarged disks not to break puppet runs
… (spec 3.0 this changed)
|
Signed the CLA as it seems required for all contributions. |
|
Any news regarding this Pull Request ? For us this is currently a blocker for using the LVM manifest, as we can not really use the manifest to do partitioning across the fleet. It would be great if this pull request could be reviewed. Thanks ! |
|
Anyone still working on this ? |
underscorgan
pushed a commit
that referenced
this pull request
Dec 1, 2014
Added Parameter 'size_is_minsize' (true|false(default))
|
@elconas sorry for the delay in getting to this, but thanks for the contribution! |
|
Thank you ! Just in Time so I finish my project this year :) |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
Added Parameter 'size_is_minsize' (true|false(default))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the times it desired to specify minimum disk settings for your application stacks (e.g. your web server should have a /var/ww space of 10GB).
However while during operations individual servers must be manually extended (//var/log is full because of a user error on a single web server of our fleet). For this operations sometimes manually intercepts. However this makes the puppet manifest fail from that moment on.
If size_is_minsize is set to true, the size parameter is actually a minsize parameter, causing the puppet manifest not to fail, if the LV we found is actually larger then we expected.
I think this is an essential feature and is needed for opertations at larger scale, expecially with outsourced highly operation teams.
Even better would be a ensure mode of "minsize", however I was not able to implement this :L)