escape dashes in lv name for dmsetup remove #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underscorgan
pushed a commit
that referenced
this pull request
Feb 4, 2015
escape dashes in lv name for dmsetup remove
|
Great, thanks @jhofeditz ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
escape dashes in lv name for dmsetup remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use dashes in our LV names and they are automatically escaped by LVM (The dashes are doubled). When we create VG myvg and LV my-lv, the lvcreate device is /dev/mapper/myvg-my--lv.
This only affects dmsetup remove. The other LVM commands and outputs use the unescaped names.
I'm not sure if a new set of tests should be created or if the current create and destroy test should be modified to use myvg/my-lv so I didn't make any spec changes.