Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-1324 Fix metadata URL and update for 0.3.4 release #83

Merged
merged 1 commit into from
Dec 1, 2014

Conversation

cyberious
Copy link
Contributor

No description provided.

@underscorgan
Copy link
Contributor

Since we aren't actually ready to release this (and as such don't know what version is going to be released) can you just update the issues url, not the changelog and version string?

@cyberious
Copy link
Contributor Author

There is a bug that we need to get out however and that is the sorting of the volume_group, previously it checks issync on a unsorted array and can be mismatched.

@underscorgan
Copy link
Contributor

@cyberious but since we're going to make it through the PRs before we look at scheduling a release there's a good chance a new feature will get in first, so it's likely that version number will be wrong.

We're going to get a release out soon, but it's not ready to be considered code complete.

@cyberious
Copy link
Contributor Author

@mhaskel addressed and removed version bump, did leave some of the comments in CHANGELOG for ease of next release.

underscorgan pushed a commit that referenced this pull request Dec 1, 2014
MODULES-1324 Fix metadata URL and update for 0.3.4 release
@underscorgan underscorgan merged commit f92f849 into puppetlabs:master Dec 1, 2014
cegeka-jenkins pushed a commit to cegeka/puppet-lvm that referenced this pull request Oct 23, 2017
MODULES-1324 Fix metadata URL and update for 0.3.4 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants