Support for readahead count when creating new volumes #90
Conversation
|
+1 for getting this merged, as I dont really want to be changing the repo and need this setting for mongo servers |
|
@jayc89 thanks for the contribution! In general this looks good, but I have one question which I'll put in an inline comment. If you can respond/fix that as relevant we should be good to merge this. |
| newparam(:readahead) do | ||
| desc "The readahead count to use for the new logical volume." | ||
| validate do |value| | ||
| unless value =~ /^([0-9]+|Auto|None)/i |
There was a problem hiding this comment.
Does lvcreate care about the casing for auto or none? If it does this parameter should have a munge block to fix the case.
There was a problem hiding this comment.
I just tried lvcreate with different casing of nOnE and AuTo, it doesn't care.
|
Would be great if this gets merged indeed! I just needed to set readahead and found this pull request! |
Support for readahead count when creating new volumes
|
Great, thanks for the contribution @jayc89 ! |
|
@mhaskel sorry to pester, any ETA on when this would get pushed to the forge? |
|
Hey @mhaskel, any idea when the next release will be cut? Thanks! |
|
Woops, sorry @seif @JamieCressey, I missed these pings. I'm not sure if we can get this out next week, but we should be able to do the following week at the latest. Thanks! |
|
@mhaskel no worries, using git ref for now. |
Support for readahead count when creating new volumes
No description provided.