Allow different values for pass and dump #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noted previously in #55 but spun off due to that mostly dealing with other changes. I didn't add any extra documentation or spec tests - please let me know if there's anything you need. I tried to keep this as simple as possible. Functionally tested on RHEL 6.5 with Puppet 3.3.2 (using Hiera for volume definition). |
|
Fixes #55 |
underscorgan
pushed a commit
that referenced
this pull request
Feb 6, 2015
Allow different values for pass and dump
|
@esalberg it doesn't look like existing tests/docs need any updates for this. thanks for the fix! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
Allow different values for pass and dump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow root filesystems to have pass specified as 1 instead of 2; allow the default dump value to be overridden if desired.