Made logical_volume $size an optional parameter #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not setting it should use the entire physical drive.
|
I was just going to query if a change like this would be acceptable. Since it's not possible to set "undef" in hiera, it would be great to have that in the code as default. ETA: I tested this change, and it allowed the following to work in hiera, which was not allowed before: Created (/dev/sdb is a new 20G volume): |
DavidS
added a commit
that referenced
this pull request
Jul 23, 2015
Made logical_volume $size an optional parameter
cegeka-jenkins
pushed a commit
to cegeka/puppet-lvm
that referenced
this pull request
Oct 23, 2017
Made logical_volume $size an optional parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not setting it should use the entire physical drive.