Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-6599) Make MOTD compatible with FreeBSD #104

Merged
merged 5 commits into from
Feb 15, 2018
Merged

(MODULES-6599) Make MOTD compatible with FreeBSD #104

merged 5 commits into from
Feb 15, 2018

Conversation

Q1tum
Copy link
Contributor

@Q1tum Q1tum commented Feb 12, 2018

MODULES-6599 - Support FreeBSD for puppet module MOTD

@smortex
Copy link
Contributor

smortex commented Feb 13, 2018

Nice! Shouldn't /etc/issue and /etc/issue.net be skipped on FreeBSD?

@Q1tum
Copy link
Contributor Author

Q1tum commented Feb 14, 2018

@smortex thanks for the suggestion, I updated this pull request.

@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 14, 2018

Hey @Q1tum,
Nice work, however we are happy enough to make the module compatible with FreeBSD although we are not prepared to support this configuration. If you remove the entries from the metadata.json I will get this PR merged. Again please be aware FreeBSD will be compatible, not supported.

@Q1tum
Copy link
Contributor Author

Q1tum commented Feb 15, 2018

Hi @pmcmaw

The metadata has been updated as requested, the main goal for me was to be able to use the module on FreeBSD in a project I'm working on, so compatible instead of supported is fine by me.

@pmcmaw pmcmaw changed the title MODULES-6599 - Support FreeBSD for MOTD MODULES-6599 - Make MOTD compatible with FreeBSD Feb 15, 2018
@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 15, 2018

This has ran through our internal CI with no issues. Squash and merging.
Thank you for your PR 👍

@pmcmaw pmcmaw merged commit 98eca9e into puppetlabs:master Feb 15, 2018
@hunner hunner added the feature label Mar 12, 2018
@hunner hunner changed the title MODULES-6599 - Make MOTD compatible with FreeBSD ([MODULES-6599](https://tickets.puppetlabs.com/browse/MODULES-6599)) Make MOTD compatible with FreeBSD Mar 12, 2018
@hunner hunner changed the title ([MODULES-6599](https://tickets.puppetlabs.com/browse/MODULES-6599)) Make MOTD compatible with FreeBSD (MODULES-6599) Make MOTD compatible with FreeBSD Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants